FEAT: Docs upgrades throughout 📈 #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquinteroflex
force-pushed
the
dario/docs_upgrades_throughout
branch
from
f7b5514
to
86d1e3d
Compare
tylerflex
requested changes
Feb 6, 2024
There was a problem hiding this comment.
Thanks @daquinteroflex I think this really improves things. Just a few minor comments.
|
one thing I fogot to mention: I think it's nice that we have some explanation of how to get to 2.6 if the link is broken. But is there a way to insert this information into a custom 404 page? (page not found. If you were trying to switch from an older version to 2.6, the link may have changed, please navigate from the main page). |
|
Yep so the 404 is in my list in the #1148 but will get to that in another PR |
daquinteroflex
force-pushed
the
dario/docs_upgrades_throughout
branch
from
86d1e3d
to
3f52e8f
Compare
daquinteroflex
force-pushed
the
dario/docs_upgrades_throughout
branch
from
3f52e8f
to
898cf7a
Compare
|
Will be probably ready to merge when these changes build btw (should be as just updating submodule) @tylerflex , the next set of docs upgrades will come in the next PR including the 404 if that sounds good |
tylerflex
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: